zinking commented on pull request #2193: URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1076093270
> > originally my intention is that this procedure could be reused in the future > > I see your concern, but it does not work if we add procedure at spark extension module. Let's say, if we add other procedures like `CREATE ENGINE` OR `DELETE ENGINE`. It should be added into Kyuubi Server module, and its scope is for all engines(Spark/Flink/Trino). > > So at present, I think it makes sense to just add this inside tpcds module. What do you think ? @zinking I guess that is the `underlying` design I would like to discuss. calling tpcds functions is really merely exercising that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
