ulysses-you commented on a change in pull request #2202:
URL: https://github.com/apache/incubator-kyuubi/pull/2202#discussion_r838116589
##########
File path:
kyuubi-server/src/test/scala/org/apache/kyuubi/events/KyuubiEventLoggingServiceSuite.scala
##########
@@ -82,7 +82,7 @@ class KyuubiEventLoggingServiceSuite extends WithKyuubiServer
with HiveJDBCTestH
val engineTable = engineStatementEventPath.getParent
val resultSet2 = statement.executeQuery(s"SELECT * FROM
`json`.`${engineTable}`" +
"where statement = \"" + sql + "\"")
- val engineStates = Array(INITIALIZED, PENDING, RUNNING, COMPILED,
FINISHED)
+ val engineStates = Array(INITIALIZED, PENDING, RUNNING, COMPILED,
COMPILED, FINISHED)
Review comment:
after some thought, I think we can remove the existed `COMPILED` (just
remove the event code):
```SCALA
// TODO #921: COMPILED need consider eagerly executed commands
setState(OperationState.COMPILED)
```
then catch the event `SparkListenerSQLExecutionStart` in
`SQLOperationListener`. At this time, we can post the `COMPILED` state event
which contains the execution id.
This approach also fix the `TODO` about the eagerly executed commands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
