cxzl25 commented on a change in pull request #2202:
URL: https://github.com/apache/incubator-kyuubi/pull/2202#discussion_r839155091



##########
File path: 
kyuubi-server/src/test/scala/org/apache/kyuubi/events/KyuubiEventLoggingServiceSuite.scala
##########
@@ -82,7 +82,7 @@ class KyuubiEventLoggingServiceSuite extends WithKyuubiServer 
with HiveJDBCTestH
       val engineTable = engineStatementEventPath.getParent
       val resultSet2 = statement.executeQuery(s"SELECT * FROM 
`json`.`${engineTable}`" +
         "where statement = \"" + sql + "\"")
-      val engineStates = Array(INITIALIZED, PENDING, RUNNING, COMPILED, 
FINISHED)
+      val engineStates = Array(INITIALIZED, PENDING, RUNNING, COMPILED, 
COMPILED, FINISHED)

Review comment:
       Sorry, after reading the Spark code, each SQL does have an executionId.
   The DDL I watched directly from the kyuubi session page yesterday did not 
show the executionId.
   That would also fix two issues by the way.
   1. ddl shows executionId.
   2. We can also remove listener when no job is generated to prevent memory 
leaks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to