cxzl25 commented on a change in pull request #2202:
URL: https://github.com/apache/incubator-kyuubi/pull/2202#discussion_r838612608
##########
File path:
kyuubi-server/src/test/scala/org/apache/kyuubi/events/KyuubiEventLoggingServiceSuite.scala
##########
@@ -82,7 +82,7 @@ class KyuubiEventLoggingServiceSuite extends WithKyuubiServer
with HiveJDBCTestH
val engineTable = engineStatementEventPath.getParent
val resultSet2 = statement.executeQuery(s"SELECT * FROM
`json`.`${engineTable}`" +
"where statement = \"" + sql + "\"")
- val engineStates = Array(INITIALIZED, PENDING, RUNNING, COMPILED,
FINISHED)
+ val engineStates = Array(INITIALIZED, PENDING, RUNNING, COMPILED,
COMPILED, FINISHED)
Review comment:
However, some DDLs do not generate jobs, so there is no executionId
e.g. use db / drop table.
But this TODO, I guess it is because the command such as insert select or
ctas will be executed directly, so TODO wants to set this state in advance.
We can do this if we allow some DDL to have no `COMPILED` status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]