hiboyang commented on code in PR #2601:
URL: https://github.com/apache/incubator-kyuubi/pull/2601#discussion_r868829665
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -186,6 +186,26 @@ object KyuubiConf {
ConfigBuilder(key).onCreate(register)
}
+ /**
+ * Create an object instance with given [[KyuubiConf]].
+ * @param clazz object class
+ * @param conf configuration ([[KyuubiConf]])
+ * @tparam T object instance type to create
+ * @return
+ */
+ def createInstance[T](clazz: Class[_], conf: KyuubiConf): T = {
Review Comment:
Sounds good
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1468,4 +1488,11 @@ object KyuubiConf {
.version("1.6.0")
.booleanConf
.createWithDefault(false)
+
+ val DISCOVERY_CLIENT_CLASS: ConfigEntry[String] =
+ buildConf("kyuubi.service.discovery.client.class")
+ .doc("Class name for service discovery client.")
+ .version("1.6.0")
Review Comment:
yes
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1468,4 +1488,11 @@ object KyuubiConf {
.version("1.6.0")
.booleanConf
.createWithDefault(false)
+
+ val DISCOVERY_CLIENT_CLASS: ConfigEntry[String] =
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
