hiboyang commented on code in PR #2601:
URL: https://github.com/apache/incubator-kyuubi/pull/2601#discussion_r869898418
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/client/DiscoveryClientProvider.scala:
##########
@@ -42,4 +43,19 @@ object DiscoveryClientProvider extends Logging {
}
}
+ def createDiscoveryClient(conf: KyuubiConf): DiscoveryClient = {
+ val classLoader = Thread.currentThread.getContextClassLoader
+ val className = conf.get(HighAvailabilityConf.DISCOVERY_CLIENT_CLASS)
+ if (className.isEmpty) {
Review Comment:
Maybe, "className.isEmpty" is a simple check, should not hurt to keep it, in
case other parts of the code have issue and do not deal with that config value
properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
