hiboyang commented on code in PR #2601:
URL: https://github.com/apache/incubator-kyuubi/pull/2601#discussion_r869858939
##########
kyuubi-ha/src/main/scala/org/apache/kyuubi/ha/HighAvailabilityConf.scala:
##########
@@ -158,4 +158,12 @@ object HighAvailabilityConf {
.version("1.5.0")
.stringConf
.createOptional
+
+ val DISCOVERY_CLIENT_CLASS: ConfigEntry[String] =
+ buildConf("kyuubi.service.discovery.client.class")
+ .doc("Class name for service discovery client.")
+ .version("1.6.0")
+ .stringConf
+ .checkValue(_.nonEmpty, "must not be empty")
Review Comment:
Here it is a string config, better avoid loading the class and check
isAssignableFrom
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
