cxzl25 commented on PR #2691: URL: https://github.com/apache/incubator-kyuubi/pull/2691#issuecomment-1129793224
> is it possible to resolve te `// TODO: Better to do this inside ProcBuilder` ? it's confused we update the conf outside the builder. So the result of commands can be immuable. So can we do this? Add the parameter `engineRefId` when constructing `ProcessBuilder`, and call `tagApplication` when `ProcessBuilder` build commands. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
