cxzl25 commented on code in PR #2691:
URL: https://github.com/apache/incubator-kyuubi/pull/2691#discussion_r875910949
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KyuubiApplicationManager.scala:
##########
@@ -88,20 +90,19 @@ class KyuubiApplicationManager extends
AbstractService("KyuubiApplicationManager
object KyuubiApplicationManager {
private def setupSparkYarnTag(tag: String, conf: KyuubiConf): Unit = {
- val originalTag = conf.getOption("spark.yarn.tags").map(_ +
",").getOrElse("")
- val newTag = s"${originalTag}KYUUBI,$tag"
- conf.set("spark.yarn.tags", newTag)
+ val originalTag = conf.getOption(SparkProcessBuilder.TAG_KEY).map(_ +
",").getOrElse("")
+ val newTag = s"${originalTag}KYUUBI" + Some(tag).map("," + _).getOrElse("")
+ conf.set(SparkProcessBuilder.TAG_KEY, newTag)
}
private def setupSparkK8sTag(tag: String, conf: KyuubiConf): Unit = {
conf.set("spark.kubernetes.driver.label.kyuubi_unique_tag", tag)
}
private def setupFlinkK8sTag(tag: String, conf: KyuubiConf): Unit = {
- // TODO: yarn.tags or flink.yarn.tags, the mess of flink settings confuses
me now.
- val originalTag = conf.getOption("yarn.tags").map(_ + ",")
- val newTag = s"${originalTag}KYUUBI,$tag"
- conf.set("yarn.tags", newTag)
+ val originalTag = conf.getOption(FlinkProcessBuilder.TAG_KEY).map(_ + ",")
+ val newTag = s"${originalTag}KYUUBI" + Some(tag).map("," + _).getOrElse("")
Review Comment:
It should be accidentally introduced by 2445, let me fix it too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
