ulysses-you commented on code in PR #2691:
URL: https://github.com/apache/incubator-kyuubi/pull/2691#discussion_r875747341
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala:
##########
@@ -37,7 +37,8 @@ import org.apache.kyuubi.operation.log.OperationLog
class FlinkProcessBuilder(
override val proxyUser: String,
override val conf: KyuubiConf,
- val extraEngineLog: Option[OperationLog] = None)
+ val extraEngineLog: Option[OperationLog] = None,
+ val engineRefId: String = "")
Review Comment:
the default value is only for simplify test code ? if so, we can add a new
constructor with comments for that to be clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
