cxzl25 commented on code in PR #2762:
URL: https://github.com/apache/incubator-kyuubi/pull/2762#discussion_r883450184
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala:
##########
@@ -90,9 +92,19 @@ object KyuubiServer extends Logging {
s" ${Properties.javaVersion}")
SignalRegister.registerLogger(logger)
val conf = new KyuubiConf().loadFileDefaults()
-
UserGroupInformation.setConfiguration(KyuubiHadoopUtils.newHadoopConf(conf))
+ hadoopConf = KyuubiHadoopUtils.newHadoopConf(conf)
+ UserGroupInformation.setConfiguration(hadoopConf)
startServer(conf)
}
+
+ private[kyuubi] def getHadoopConf(): Configuration = {
+ hadoopConf
+ }
+
+ private[kyuubi] def reloadHadoopConf(): Unit = synchronized {
Review Comment:
Not related to this PR.
Can we also implement `reloadkyuubiConf`?
Because some configurations are actually for the engine, when the engine
parameters related to `kyuubi-defaults.conf` are modified or added, the new
engine parameters submitted by the server will not take effect, and only after
restarting the server will it take effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
