turboFei commented on code in PR #2762:
URL: https://github.com/apache/incubator-kyuubi/pull/2762#discussion_r883455427
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala:
##########
@@ -90,9 +92,19 @@ object KyuubiServer extends Logging {
s" ${Properties.javaVersion}")
SignalRegister.registerLogger(logger)
val conf = new KyuubiConf().loadFileDefaults()
-
UserGroupInformation.setConfiguration(KyuubiHadoopUtils.newHadoopConf(conf))
+ hadoopConf = KyuubiHadoopUtils.newHadoopConf(conf)
+ UserGroupInformation.setConfiguration(hadoopConf)
startServer(conf)
}
+
+ private[kyuubi] def getHadoopConf(): Configuration = {
+ hadoopConf
+ }
+
+ private[kyuubi] def reloadHadoopConf(): Unit = synchronized {
Review Comment:
kyuubi conf is widely used and you might need re-initialize many components,
so it seems more complex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
