cxzl25 commented on code in PR #2762:
URL: https://github.com/apache/incubator-kyuubi/pull/2762#discussion_r883609840
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala:
##########
@@ -90,9 +92,19 @@ object KyuubiServer extends Logging {
s" ${Properties.javaVersion}")
SignalRegister.registerLogger(logger)
val conf = new KyuubiConf().loadFileDefaults()
-
UserGroupInformation.setConfiguration(KyuubiHadoopUtils.newHadoopConf(conf))
+ hadoopConf = KyuubiHadoopUtils.newHadoopConf(conf)
+ UserGroupInformation.setConfiguration(hadoopConf)
startServer(conf)
}
+
+ private[kyuubi] def getHadoopConf(): Configuration = {
+ hadoopConf
+ }
+
+ private[kyuubi] def reloadHadoopConf(): Unit = synchronized {
Review Comment:
I agree with you. @turboFei
Reloading `kyuubiConf` rashly may still have side effects.
Configuration refresh is also implemented in HDFS, using the `hdfs dfsadmin
-reconfig` command, it will only refresh the configuration items marked
refreshable to protect the configuration.
Because `SessionConfAdvisor` can only set session-level parameters, and then
in JDBC mode, the cost of server restart is relatively high.
Maybe we can design how to achieve better dynamic configuration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
