turboFei commented on code in PR #2909:
URL: https://github.com/apache/incubator-kyuubi/pull/2909#discussion_r900925220


##########
kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/cmd/submit/SubmitBatchCommand.scala:
##########
@@ -35,10 +35,11 @@ class SubmitBatchCommand(cliConfig: CliConfig) extends 
Command[Batch](cliConfig)
 
     val createBatchCommand = new CreateBatchCommand(normalizedCliConfig)
     val batchId = createBatchCommand.doRun().getId

Review Comment:
   transfer the result of `CreateBatchCommand` to `LogBatchCommand`



##########
kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala:
##########
@@ -46,41 +46,73 @@ class LogBatchCommand(cliConfig: CliConfig, restConfigMap: 
JMap[String, Object]
 
       var log: OperationLog = null
       var done = false
-      var batch: Batch = null
+      var batch: Batch = batchRestApi.getBatchById(batchId)

Review Comment:
   could you transfer the batch report to `LogBatchCommand`.
   
   It is for the corner case when jdbc metastore is down.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org

Reply via email to