[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2909: [KYUUBI #2628][FOLLOWUP] Support waitUntilComplete for submit batch

[GitBox]

turboFei commented on code in PR #2909:
URL: https://github.com/apache/incubator-kyuubi/pull/2909#discussion_r901074772


##########
kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/cmd/create/CreateBatchCommand.scala:
##########
@@ -38,12 +40,14 @@ class CreateBatchCommand(cliConfig: CliConfig) extends 
Command[Batch](cliConfig)
       val batchRestApi: BatchRestApi = new BatchRestApi(kyuubiRestClient)
 
       val request = map.get("request").asInstanceOf[HashMap[String, Object]]
+      val config = request.get("configs").asInstanceOf[HashMap[Object, 
Object]].asScala

Review Comment:
   nit:
   ```
   import java.util.{ArrayList, Map => JMap}
   
    asInstanceOf[JMap[Object, Object]]
   ```



##########
kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/cmd/create/CreateBatchCommand.scala:
##########
@@ -38,12 +40,14 @@ class CreateBatchCommand(cliConfig: CliConfig) extends 
Command[Batch](cliConfig)
       val batchRestApi: BatchRestApi = new BatchRestApi(kyuubiRestClient)
 
       val request = map.get("request").asInstanceOf[HashMap[String, Object]]
+      val config = request.get("configs").asInstanceOf[HashMap[Object, 
Object]].asScala

Review Comment:
   nit:
   ```
   import java.util.{ArrayList, Map => JMap}
   
   asInstanceOf[JMap[Object, Object]]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org