[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #2909: [KYUUBI #2628][FOLLOWUP] Support waitUntilComplete for submit batch

[GitBox]

turboFei commented on code in PR #2909:
URL: https://github.com/apache/incubator-kyuubi/pull/2909#discussion_r901074182


##########
kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala:
##########
@@ -46,41 +49,73 @@ class LogBatchCommand(cliConfig: CliConfig, restConfigMap: 
JMap[String, Object]
 
       var log: OperationLog = null
       var done = false
-      var batch: Batch = null
+      var batch: Batch = if (this.batch == null) 
batchRestApi.getBatchById(batchId) else this.batch

Review Comment:
   ```
         var batch: Batch = if (this.batch == null) {
             batchRestApi.getBatchById(batchId)
          } else {
             this.batch
          }
   ```



##########
kyuubi-ctl/src/main/scala/org/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala:
##########
@@ -46,41 +49,73 @@ class LogBatchCommand(cliConfig: CliConfig, restConfigMap: 
JMap[String, Object]
 
       var log: OperationLog = null
       var done = false
-      var batch: Batch = null
+      var batch: Batch = if (this.batch == null) 
batchRestApi.getBatchById(batchId) else this.batch

Review Comment:
   ```
         var batch = if (this.batch == null) {
             batchRestApi.getBatchById(batchId)
          } else {
             this.batch
          }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org