pan3793 commented on code in PR #4147:
URL: https://github.com/apache/kyuubi/pull/4147#discussion_r1068977304
##########
charts/kyuubi/templates/_helpers.tpl:
##########
@@ -16,33 +16,18 @@
*/}}
{{/*
-Expand the name of the chart.
+A comma separated string of enabled frontend protocols, e.g.
"MYSQL,REST,THRIFT_BINARY".
Review Comment:
"MYSQL" is experimental, let's use "REST,THRIFT_BINARY" as example.
##########
charts/kyuubi/values.yaml:
##########
@@ -57,12 +57,60 @@ probe:
failureThreshold: 10
successThreshold: 1
-server:
- bind:
- host: 0.0.0.0
+# Kyuubi frontends
+frontend:
Review Comment:
it's not necessary to expose the frontend/backend concept to end users. I
propose the structure here is
```
kyuubi
thriftBinary:
xxxx
thriftHTTP:
xxxx
# other protocols information
confDir:
conf:
kyuubiDefaults:
kyuubiEnv:
spark:
confDir:
conf:
sparkConfDefaults:
sparkConfEnv:
``
##########
charts/kyuubi/templates/kyuubi-deployment.yaml:
##########
@@ -57,13 +57,16 @@ spec:
envFrom: {{- tpl (toYaml .) $ | nindent 12 }}
{{- end }}
ports:
- - name: frontend-port
- containerPort: {{ .Values.server.bind.port }}
- protocol: TCP
+ {{- range $name, $frontend := .Values.frontend }}
+ {{- if $frontend.enabled }}
+ - name: {{ $name | kebabcase }}
+ containerPort: {{ $frontend.port }}
+ {{- end }}
+ {{- end }}
{{- if .Values.probe.liveness.enabled }}
livenessProbe:
- tcpSocket:
- port: {{ .Values.server.bind.port }}
+ exec:
+ command: ["/bin/sh", "-c", "bin/kyuubi status"]
Review Comment:
can we use `/bin/bash` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
