pan3793 commented on code in PR #4147: URL: https://github.com/apache/kyuubi/pull/4147#discussion_r1068996020
########## charts/kyuubi/values.yaml: ########## @@ -57,12 +57,60 @@ probe: failureThreshold: 10 successThreshold: 1 -server: - bind: - host: 0.0.0.0 +# Kyuubi frontends +frontend: Review Comment: it's not necessary to expose the frontend/backend concept to end users. I propose the structure here is ``` kyuubi thriftBinary: xxxx thriftHTTP: xxxx # other protocols information confDir: conf: kyuubiDefaults: kyuubiEnv: spark: confDir: conf: sparkDefaults: sparkEnv: `` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org