dnskr commented on code in PR #4147:
URL: https://github.com/apache/kyuubi/pull/4147#discussion_r1070166017
##########
charts/kyuubi/templates/kyuubi-deployment.yaml:
##########
@@ -57,13 +57,16 @@ spec:
envFrom: {{- tpl (toYaml .) $ | nindent 12 }}
{{- end }}
ports:
- - name: frontend-port
- containerPort: {{ .Values.server.bind.port }}
- protocol: TCP
+ {{- range $name, $frontend := .Values.frontend }}
+ {{- if $frontend.enabled }}
+ - name: {{ $name | kebabcase }}
+ containerPort: {{ $frontend.port }}
+ {{- end }}
+ {{- end }}
{{- if .Values.probe.liveness.enabled }}
livenessProbe:
- tcpSocket:
- port: {{ .Values.server.bind.port }}
+ exec:
+ command: ["/bin/sh", "-c", "bin/kyuubi status"]
Review Comment:
Yes, you are right. It would be better at least because `kyuubi/bin`
scpripts use `bash`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
