turboFei commented on code in PR #4144:
URL: https://github.com/apache/kyuubi/pull/4144#discussion_r1073183882
##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/api/v1/dto/BatchRequest.java:
##########
@@ -32,6 +32,9 @@ public class BatchRequest {
private Map<String, String> conf;
private List<String> args;
+ /** whether clean up temporary uploaded resource file in local path after
execution */
+ private Boolean cleanupResourceFile = false;
Review Comment:
Seems we do not need expose this field in API, just always remove uploaded
files?
##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/api/v1/dto/BatchRequest.java:
##########
@@ -32,6 +32,9 @@ public class BatchRequest {
private Map<String, String> conf;
private List<String> args;
+ /** whether clean up temporary uploaded resource file in local path after
execution */
+ private Boolean cleanupResourceFile = false;
Review Comment:
Seems we do not need to expose this field in API, just always remove
uploaded files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
