turboFei commented on code in PR #4144:
URL: https://github.com/apache/kyuubi/pull/4144#discussion_r1073188527


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala:
##########
@@ -300,6 +308,20 @@ class BatchJobSubmission(
     }
   }
 
+  private def deleteTempLocalResourceFile(filePath: String): Unit = {
+    try {
+      val uri = new URI(filePath)
+      uri.getScheme match {
+        case null | "file" =>
+          FileUtils.deleteQuietly(Paths.get(filePath).toFile)
+        case _ =>
+          warn(s"only local path supported, skip deleting file $filePath")
+      }
+    } catch {
+      case e: Exception => warn(e)

Review Comment:
   log more helpful information, including the resource path and action.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org

Reply via email to