turboFei commented on code in PR #4144:
URL: https://github.com/apache/kyuubi/pull/4144#discussion_r1073189574


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/operation/KyuubiOperationManager.scala:
##########
@@ -81,7 +81,8 @@ class KyuubiOperationManager private (name: String) extends 
OperationManager(nam
       className: String,
       batchConf: Map[String, String],
       batchArgs: Seq[String],
-      recoveryMetadata: Option[Metadata]): BatchJobSubmission = {
+      recoveryMetadata: Option[Metadata],
+      isCleanupResourceFile: Boolean): BatchJobSubmission = {

Review Comment:
   how about get it from `KyuubiBatchSessionImpl`, because we need to check the 
option to determine whether check the resource path in `KyuubiBatchSessionImpl` 
as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org

Reply via email to