bowenliang123 commented on code in PR #4144:
URL: https://github.com/apache/kyuubi/pull/4144#discussion_r1073343588
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/Utils.scala:
##########
@@ -135,6 +135,19 @@ object Utils extends Logging {
f.delete()
}
+ /**
+ * Create a temporary file inside the given parent directory. The file will
be
+ * automatically deleted when the VM shuts down.
+ */
+ def createTempFile(
+ dir: Path,
+ prefix: String,
+ suffix: String): File = {
+ val f = Files.createTempFile(dir, prefix, suffix).toFile
+ f.deleteOnExit()
+ f
Review Comment:
Removed. Thx for the catch.
##########
kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/api/v1/dto/BatchRequest.java:
##########
@@ -32,6 +32,9 @@ public class BatchRequest {
private Map<String, String> conf;
private List<String> args;
+ /** whether clean up temporary uploaded resource file in local path after
execution */
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
