turboFei commented on code in PR #4144:
URL: https://github.com/apache/kyuubi/pull/4144#discussion_r1073199259
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSessionImpl.scala:
##########
@@ -80,6 +80,7 @@ class KyuubiBatchSessionImpl(
override lazy val name: Option[String] = Option(batchRequest.getName).orElse(
normalizedConf.get(KyuubiConf.SESSION_NAME.key))
+ // todo: support uploaded app jar
private[kyuubi] lazy val batchJobSubmissionOp =
sessionManager.operationManager
Review Comment:
how about moving this TODO to `BatchResource` or just remove it?
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiBatchSessionImpl.scala:
##########
@@ -80,6 +80,7 @@ class KyuubiBatchSessionImpl(
override lazy val name: Option[String] = Option(batchRequest.getName).orElse(
normalizedConf.get(KyuubiConf.SESSION_NAME.key))
+ // todo: support uploaded app jar
private[kyuubi] lazy val batchJobSubmissionOp =
sessionManager.operationManager
Review Comment:
how about moving this TODO into `BatchResource` or just remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
