bowenliang123 commented on code in PR #4643:
URL: https://github.com/apache/kyuubi/pull/4643#discussion_r1154538369
##########
extensions/spark/kyuubi-spark-authz/src/test/scala/org/apache/kyuubi/plugin/spark/authz/ranger/RangerSparkExtensionSuite.scala:
##########
@@ -388,6 +389,19 @@ abstract class RangerSparkExtensionSuite extends
AnyFunSuite
assert(sql(s"SELECT value1 FROM $db.${table}2").collect() ===
Seq(Row(DigestUtils.md5Hex("1"))))
})
+
+ doAs(
+ "admin",
+ sql(
+ s"INSERT INTO $db.$table SELECT 10, 1, 'hello', " +
+ s"'\u6d4b\u8bd5\u4e2d\u6587\u524d\u56db\u4e2aabcABC', " +
Review Comment:
No. Source code do support utf8 chars including Chinese. Also, you would
prefer reformatting tool for lining and consider inline-method comments.
Comments are meant to make the case readable and easy to understand, especially
you don't have exact Chinese words in the sql.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
