huangzhir commented on PR #4643: URL: https://github.com/apache/kyuubi/pull/4643#issuecomment-1495285363
hello ,I'd like to request your help to review my PR. Based on @bowenliang123 @yaooqinn your feedback, I've made some changes to the code and re-submitted the PR. The changes include: Replacing all non-English letters, numbers, and spaces with the letter 'U'. This will ensure that all Unicode character sets for all languages are properly masked. Adding unit tests specifically for regexp_replace, maskShowFirst4, and maskShowLast4. @bowenliang123 Could you please review my changes and let me know if there's anything else I can improve on? Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
