bowenliang123 commented on PR #4643: URL: https://github.com/apache/kyuubi/pull/4643#issuecomment-1493229672
This PR is not quite persuasive to me for now. I would like to see, 1. an explanation and implementation of different kinds of unicode chars. AndAgain Chinese is just one type of them, so PR 2. not sure relation between unicode chars and utf8 chars, whether in stored data itself or inside Spark engine 2. short of e2e test, to masking data in data in table 3. short of convincing test to test each case separately , all the ut mixed together , and part of tests limited to 3.2+ If this PR keeps to fix Chinese chars only (and only within the basic unicode range), I think I would not to pass it. And I would like to hear any idea from @yaooqinn @pan3793 @Yikf @zhouyifan279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
