pan3793 commented on code in PR #4733:
URL: https://github.com/apache/kyuubi/pull/4733#discussion_r1187164694
##########
pom.xml:
##########
@@ -1261,6 +1268,18 @@
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.kafka</groupId>
+ <artifactId>kafka-clients</artifactId>
+ <version>${kafka.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
We should respect the Maven transitive dependencies in most cases, just
excluding the deps we truly don't need, and overriding versions in
`dependencyManagement`(just overriding, without excluding)
But it's not suitable for components which is disastrous for dependencies
management, like Hive, Hudi.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
