pan3793 commented on code in PR #4733:
URL: https://github.com/apache/kyuubi/pull/4733#discussion_r1187255697
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -2006,12 +2006,34 @@ object KyuubiConf {
.stringConf
.createWithDefault("file:///tmp/kyuubi/events")
+ val SERVER_EVENT_KAFKA_TOPIC: OptionalConfigEntry[String] =
+ buildConf("kyuubi.backend.server.event.kafka.topic")
+ .doc("The topic of server events go for the built-in Kafka logger")
+ .version("1.8.0")
+ .serverOnly
+ .stringConf
+ .createOptional
+
+ val SERVER_EVENT_KAFKA_CLOSE_TIMEOUT: ConfigEntry[Long] =
+ buildConf("kyuubi.backend.server.event.kafka.close.timeout")
+ .doc("Period to wait for Kafka producer of server event handlers to
close.")
+ .version("1.8.0")
+ .serverOnly
+ .timeConf
+ .createWithDefault(Duration.ofMillis(5000).toMillis)
+
val SERVER_EVENT_LOGGERS: ConfigEntry[Seq[String]] =
buildConf("kyuubi.backend.server.event.loggers")
.doc("A comma-separated list of server history loggers, where
session/operation etc" +
" events go.<ul>" +
s" <li>JSON: the events will be written to the location of" +
s" ${SERVER_EVENT_JSON_LOG_PATH.key}</li>" +
+ s" <li>KAFKA: the events serialized in JSON format" +
+ s" and sent to topic of `${SERVER_EVENT_KAFKA_TOPIC.key}`. " +
+ s" Note: For the configs of Kafka producer," +
+ s" please specify them with the prefix:
`kyuubi.backend.server.event.kafka.`." +
+ s" For example,
kyuubi.backend.server.event.kafka.bootstrap.servers=127.0.0.1:9092" +
Review Comment:
```suggestion
s" <li>KAFKA: the events will be serialized in JSON format" +
s" and sent to topic of `${SERVER_EVENT_KAFKA_TOPIC.key}`." +
s" Note: For the configs of Kafka producer," +
s" please specify them with the prefix:
`kyuubi.backend.server.event.kafka.`." +
s" For example,
`kyuubi.backend.server.event.kafka.bootstrap.servers=127.0.0.1:9092`" +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
