bowenliang123 commented on code in PR #4733:
URL: https://github.com/apache/kyuubi/pull/4733#discussion_r1187247314
##########
kyuubi-events/src/main/scala/org/apache/kyuubi/events/EventLoggerType.scala:
##########
@@ -21,6 +21,5 @@ object EventLoggerType extends Enumeration {
type EventLoggerType = Value
- // TODO: Only SPARK is done now
- val SPARK, JSON, JDBC, CUSTOM = Value
+ val SPARK, JSON, JDBC, CUSTOM, KAFKA = Value
Review Comment:
I think this TODO can be removed. Not all the event logger types in both
servers or the engine. It's a legacy todo hints.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
