link3280 commented on code in PR #5093:
URL: https://github.com/apache/kyuubi/pull/5093#discussion_r1275769876
##########
externals/kyuubi-flink-sql-engine/src/main/scala/org/apache/kyuubi/engine/flink/result/ResultSetUtil.scala:
##########
@@ -84,34 +89,10 @@ object ResultSetUtil {
case _: InterruptedException => fetched.getNextToken == null
}
} while (
- fetched.getNextToken != null &&
+ System.currentTimeMillis() - fetchStart < fetchTimeout &&
Review Comment:
Neither. The timeout is designed to prevent Flink engine from keep fetching
results endlessly. If the timeout is reached, Flink engine would stop fetching
more rows and return the result set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
