link3280 commented on code in PR #5093:
URL: https://github.com/apache/kyuubi/pull/5093#discussion_r1280078505
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1319,6 +1319,14 @@ object KyuubiConf {
.intConf
.createWithDefault(1000000)
+ val ENGINE_FLINK_FETCH_TIMEOUT: ConfigEntry[Long] =
+ buildConf("kyuubi.session.engine.flink.fetch.timeout")
+ .doc("Result fetch timeout. Flink would keep fetching result until " +
+ "either the max rows limit is reached or the timeout is reached.")
+ .version("1.8.0")
+ .timeConf
+ .createWithDefault(Duration.ofMinutes(5).toMillis)
Review Comment:
It looks like we need to make a trade-off between batch queries and stream
queries. For batch queries (bounded), the result should be complete, and the
timeout should be optional or set to a greater value. While for stream queries
(usually unbonded), the result would never be complete, thus select queries are
just used for taking a peek and the completeness is not a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
