pan3793 commented on code in PR #5093:
URL: https://github.com/apache/kyuubi/pull/5093#discussion_r1279219360
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1319,6 +1319,14 @@ object KyuubiConf {
.intConf
.createWithDefault(1000000)
+ val ENGINE_FLINK_FETCH_TIMEOUT: ConfigEntry[Long] =
+ buildConf("kyuubi.session.engine.flink.fetch.timeout")
+ .doc("Result fetch timeout. Flink would keep fetching result until " +
+ "either the max rows limit is reached or the timeout is reached.")
+ .version("1.8.0")
+ .timeConf
+ .createWithDefault(Duration.ofMinutes(5).toMillis)
Review Comment:
this actually could cut the result off and silently returns in-completed
results to the client. can we make it optional and leave the default value as
None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
