bowenliang123 commented on PR #5248: URL: https://github.com/apache/kyuubi/pull/5248#issuecomment-1705981965
Hi @yabola, thanks for the contribution to the Authz plugin. And pleased to see introducing support for CALL statements for Iceberg which are critical to lakehouse lifecycle. Some advices here, 1. Move the command spec generation to `authz.gen` package's `IcebergCommands`, which then is used in `JsonSpecFileGenerator` for spec json file generation by running `dev/gen/gen_ranger_spec_json.sh` locally . And also running `KYUUBI_UPDATE=0 dev/gen/gen_ranger_spec_json.sh` to check spec file. 2. if possible, try not to introduce a new TableExtractor specifically for Iceberg. Iceberg commands are generally supported with existed extractors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
