yabola commented on PR #5248: URL: https://github.com/apache/kyuubi/pull/5248#issuecomment-1706316310
1. I have moved to `IcebergCallCommand`. Sorry didn't notice... 3. Yes, there should share the same common structure. I think we'd better use the `table` parameter instead of `identifier` here. The reason: > The identifier in DataSourceV2Relation is not reliable enough. In fact, datasourceV2 will parse out the table based on identifier, so table is more appropriate here. For example, in iceberg rewrite_data_files command, identifier is rewrite task id, iceberg catalog will load table by it ( can see in SparkCatalog#load the isPathIdentifier function) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
