bowenliang123 commented on PR #5248: URL: https://github.com/apache/kyuubi/pull/5248#issuecomment-1706261329
1. Please move `IcebergCallCommand ` to `IcebergCommands` class as mentioned above, as `org.apache.spark.sql.catalyst.plans.logical.Call` is from Iceberg but not a general plan from Spark engine. And result spec file is check by CI tests. 2. It's feasible to introduce a new table extractor for the Call plan. 3. Try not to introduce `resolveIcebergTable` in `tableExtractors`, and do the extraction by reusing existed extractors following the main procedures. Reversed coupling is always unwelcomed. Any other lakehouse may and will be supported by design with in separated command extractors and specs, while sharing the same common structure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
