bowenliang123 commented on PR #5248: URL: https://github.com/apache/kyuubi/pull/5248#issuecomment-1709410253
Pleased to see the progress of the added e2e tests which passed CI tests. Still some concerns in the following changes, that I may have further investigation or proof. 1. Again, change the source field inside the `DataSourceV2RelationTableExtractor`, from "identifier" to `Table` "table" 2. the introduced `StringTableExtractor` 3. forced casting to Literal in `IcebergCallArgsTableExtractor ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
