dnskr commented on code in PR #5281:
URL: https://github.com/apache/kyuubi/pull/5281#discussion_r1332170642
##########
charts/kyuubi/templates/kyuubi-statefulset.yaml:
##########
@@ -75,6 +75,10 @@ spec:
containerPort: {{ $frontend.port }}
{{- end }}
{{- end }}
+ {{- if .Values.monitoring.prometheus.enabled }}
+ - name: prometheus
+ containerPort: {{ .Values.monitoring.prometheus.port}}
Review Comment:
Please, add one space after `port` here as well. I know that it's me who
suggested changes without the space., sorry for that.
```yaml
containerPort: {{ .Values.monitoring.prometheus.port }}
```
##########
charts/kyuubi/templates/kyuubi-headless-service.yaml:
##########
@@ -30,6 +30,11 @@ spec:
port: {{ tpl $frontend.service.port $ }}
targetPort: {{ $frontend.port }}
{{- end }}
+ {{- if .Values.monitoring.prometheus.enabled }}
+ - name: prometheus
+ port: {{ .Values.monitoring.prometheus.port}}
+ targetPort: {{ .Values.monitoring.prometheus.port}}
Review Comment:
Please, add one space after `port`
```yaml
port: {{ .Values.monitoring.prometheus.port }}
targetPort: {{ .Values.monitoring.prometheus.port }}
```
##########
charts/kyuubi/templates/kyuubi-service.yaml:
##########
@@ -15,7 +15,7 @@
limitations under the License.
*/}}
-{{- range $name, $frontend := .Values.server }}
+{{- range $name, $frontend := merge .Values.server .Values.monitoring }}
Review Comment:
Let's do not add it here then, i.e. let's remove changes in the file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
