dnskr commented on code in PR #5281:
URL: https://github.com/apache/kyuubi/pull/5281#discussion_r1362820610
##########
charts/kyuubi/values.yaml:
##########
@@ -116,13 +116,14 @@ server:
nodePort: ~
annotations: {}
+monitoring:
# Exposes metrics in Prometheus format
prometheus:
enabled: true
port: 10019
service:
Review Comment:
Sorry for the delay, I missed your last comment.
I think that Prometheus metrics endpoint doesn't require dedicated `Service`
and I don't remember I saw it in other Helm charts. So it's fine that you
deleted it and we have `prometheus` port in Kyuubi headless service only.
In the current implementation `{{ .Values.monitoring.prometheus.port }}`
value is used for `prometheus` port of the container and `Service` ports (port
and targetPort), which is also fine. So, if none of `{{
.Values.monitoring.prometheus.service.* }}` values are used, I would suggest to
delete them for now and add them later if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
