dnskr commented on code in PR #5281:
URL: https://github.com/apache/kyuubi/pull/5281#discussion_r1339294213
##########
charts/kyuubi/values.yaml:
##########
@@ -116,13 +116,14 @@ server:
nodePort: ~
annotations: {}
+monitoring:
# Exposes metrics in Prometheus format
prometheus:
enabled: true
port: 10019
service:
Review Comment:
Only `monitoring.prometheus.enabled` and `monitoring.prometheus.port` are
used as I can see.
[charts/kyuubi/templates/kyuubi-headless-service.yaml](https://github.com/apache/kyuubi/pull/5281/files#diff-a15690f05b8022769e74321d33a3f77de06a647df4f0d5c34aad721a9a92bb6a)
```yaml
{{- if .Values.monitoring.prometheus.enabled }}
- name: prometheus
port: {{ .Values.monitoring.prometheus.port }}
targetPort: {{ .Values.monitoring.prometheus.port }}
{{- end }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
