pan3793 commented on code in PR #5866:
URL: https://github.com/apache/kyuubi/pull/5866#discussion_r1428814717
##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/session/HiveSessionImpl.scala:
##########
@@ -63,7 +67,16 @@ class HiveSessionImpl(
case TGetInfoType.CLI_SERVER_NAME => TGetInfoValue.stringValue("Hive")
case TGetInfoType.CLI_DBMS_NAME => TGetInfoValue.stringValue("Apache
Hive")
case TGetInfoType.CLI_DBMS_VER =>
TGetInfoValue.stringValue(HiveVersionInfo.getVersion)
- case TGetInfoType.CLI_ODBC_KEYWORDS =>
TGetInfoValue.stringValue("Unimplemented")
+ case TGetInfoType.CLI_ODBC_KEYWORDS =>
+ if
(SemanticVersion(HiveVersionInfo.getVersion).isVersionAtLeast("3.0.0")) {
+ val keywords = invokeAs[String](
Review Comment:
prefer to use `Dyn*` classes in engine modules, the chain syntax is much
clearer to reflect the API evolution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
