Yikf commented on code in PR #5866:
URL: https://github.com/apache/kyuubi/pull/5866#discussion_r1429116096
##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/session/HiveSessionImpl.scala:
##########
@@ -83,3 +96,244 @@ class HiveSessionImpl(
}
}
}
+
+object HiveSessionImpl {
+ // scalastyle:off line.size.limit
+ // From
https://docs.microsoft.com/en-us/sql/t-sql/language-elements/reserved-keywords-transact-sql#odbc-reserved-keywords
+ // scalastyle:on line.size.limit
+ final val ODBC_KEYWORDS = Sets.newHashSet(
Review Comment:
In fact, want to be consistent with [Hive
behavior](https://github.com/apache/hive/blob/master/service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java#L508),
But it's okay to expose all of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
