pan3793 commented on code in PR #5866: URL: https://github.com/apache/kyuubi/pull/5866#discussion_r1428815851
########## externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/session/HiveSessionImpl.scala: ########## @@ -21,16 +21,20 @@ import java.util import scala.collection.JavaConverters._ +import com.google.common.collect.Sets Review Comment: be careful on using Guava API in Hive engines, the relocation will be broken once we invoke the Hive method which leaks Guava classes. we already suffered that in thrift and eventually had to create a pre-relocated thrift jar to work around it. ########## externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/session/HiveSessionImpl.scala: ########## @@ -21,16 +21,20 @@ import java.util import scala.collection.JavaConverters._ +import com.google.common.collect.Sets Review Comment: be careful on using Guava API in Hive engine, the relocation will be broken once we invoke the Hive method which leaks Guava classes. we already suffered that in thrift and eventually had to create a pre-relocated thrift jar to work around it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
