davidyuan1223 commented on code in PR #6365: URL: https://github.com/apache/kyuubi/pull/6365#discussion_r1597374566
########## externals/kyuubi-spark-connect-engine/src/main/resources/protobuf/kyuubi/spark/connect/base.proto: ########## Review Comment: @ulysses-you yes, but i think, maybe we need to add other request/response, so my plan is put the proto files in kyuubi grpc, we can add kyuubi's interface based on the spark-connect proto, so not add the spark-connect common dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
