davidyuan1223 commented on code in PR #6365: URL: https://github.com/apache/kyuubi/pull/6365#discussion_r1597399907
########## externals/kyuubi-spark-connect-engine/src/main/resources/protobuf/kyuubi/spark/connect/base.proto: ########## Review Comment: > Can you elaborate your plan ? I'm afrait things becomes complex if we decide to support connect based on proto. Actually, it's a assume, because the proto is based on spark, if we wanna support it with another engine, maybe need modify the proto? So i think put the proto in kyuubi-grpc could help us compite with other sql engine in the future. And if we wanna add spark-connect-common dependency, we need the spark version > 3.4, i think it's not compitable with other versions, because the rpc request will be handle by kyuubi's grpc backendService, not spark's rpc server, based on the proto, we could support rpc process in other spark version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
