ulysses-you commented on code in PR #6365: URL: https://github.com/apache/kyuubi/pull/6365#discussion_r1597407600
########## externals/kyuubi-spark-connect-engine/src/main/resources/protobuf/kyuubi/spark/connect/base.proto: ########## Review Comment: > So i think put the proto in kyuubi-grpc could help us compite with other sql engine in the future. It's too early to consider that. Even if we add proto, there is no standard proto interface, how can Spark proto compatible with other engine ? For each proto based engine, I think we can also add their server dependency. > And if we wanna add spark-connect-common dependency, we need the spark version > 3.4, i think it's not compitable with other versions, because the rpc request will be handle by kyuubi's grpc backendService, not spark's rpc server, based on the proto, we could support rpc process in other spark version It sounds like just like copy all Spark connect server code into Kyuubi repo ? I think we only need to support connect since Spark3.5 and later, that's why we need a new module for Kyuubi Server. We do not need support older Spark version. ---- Besides, Add a Kyuubi grpc proto is fine to me for those statements, e.g., show kyuubi session/operators etc which are for Kyuubi itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
