pan3793 commented on code in PR #6530: URL: https://github.com/apache/kyuubi/pull/6530#discussion_r1675628506
########## bin/kyuubi: ########## @@ -102,7 +102,7 @@ if [[ -n ${YARN_CONF_DIR} ]]; then KYUUBI_CLASSPATH="${KYUUBI_CLASSPATH}:${YARN_CONF_DIR}" fi -cmd="${RUNNER} ${KYUUBI_JAVA_OPTS} -cp ${KYUUBI_CLASSPATH} $CLASS" +cmd="${RUNNER} ${KYUUBI_JAVA_OPTS} -cp ${KYUUBI_CLASSPATH} $CLASS ${@:2}" Review Comment: it also allows `bin/kyuubi` without command. I think we can shift the consumed args and pass `$@` here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org