pan3793 commented on code in PR #6530:
URL: https://github.com/apache/kyuubi/pull/6530#discussion_r1677266627
##########
bin/kyuubi:
##########
@@ -102,7 +102,7 @@ if [[ -n ${YARN_CONF_DIR} ]]; then
KYUUBI_CLASSPATH="${KYUUBI_CLASSPATH}:${YARN_CONF_DIR}"
fi
-cmd="${RUNNER} ${KYUUBI_JAVA_OPTS} -cp ${KYUUBI_CLASSPATH} $CLASS"
+cmd="${RUNNER} ${KYUUBI_JAVA_OPTS} -cp ${KYUUBI_CLASSPATH} $CLASS ${@:2}"
Review Comment:
> Why do we need to support running Kyuubi as a daemon with `bin/kyuubi`
without `start` command?
this is a behavior from the very beginning, let's keep it to avoid breaking
the user experience
> ... so in current implementation `restart` command requires users to
provide the same `--conf` options was used with `start` command.
I see, and it is reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
