dnskr commented on code in PR #6530:
URL: https://github.com/apache/kyuubi/pull/6530#discussion_r1676027345


##########
bin/kyuubi:
##########
@@ -102,7 +102,7 @@ if [[ -n ${YARN_CONF_DIR} ]]; then
   KYUUBI_CLASSPATH="${KYUUBI_CLASSPATH}:${YARN_CONF_DIR}"
 fi
 
-cmd="${RUNNER} ${KYUUBI_JAVA_OPTS} -cp ${KYUUBI_CLASSPATH} $CLASS"
+cmd="${RUNNER} ${KYUUBI_JAVA_OPTS} -cp ${KYUUBI_CLASSPATH} $CLASS ${@:2}"

Review Comment:
   @pan3793 Thanks, I missed that case.
   
   Why do we need to support running Kyuubi as a daemon with `bin/kyuubi` 
without `start` command? At first look, it would be more expected to me to 
print help message if no command provided by user. I can create a PR if you 
think it is a good change.
   
   Also I found another interesting case. As a user, I would expect `restart` 
to launch Kyuubi with the same configs was used to launch Kyuubi with `start` 
command initially. Not sure how to manage it automatically, so in current 
implementation `restart` command requires users to provide the same `--conf` 
options was used with `start` command.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org

Reply via email to