zhangxinyao88 commented on code in PR #7766:
URL: https://github.com/apache/kyuubi/pull/7766#discussion_r4117953564
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -132,7 +128,7 @@
<dependency>
<groupId>org.apache.ranger</groupId>
- <artifactId>ranger-plugins-audit</artifactId>
+ <artifactId>ranger-audit-dest-hdfs</artifactId>
Review Comment:
> expected?\n\n`ranger-plugins-audit` was removed in Ranger 2.7 and split
into six destination artifacts. The latest commit restores the equivalent
CloudWatch, Elasticsearch, HDFS, Kafka, Log4j, and Solr destinations while
retaining the client-library exclusions.
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -221,6 +217,26 @@
</exclusions>
</dependency>
+ <dependency>
+ <groupId>org.apache.ranger</groupId>
+ <artifactId>ranger-audit-dest-solr</artifactId>
+ <version>${ranger.version}</version>
+ <exclusions>
+ <exclusion>
+ <groupId>org.apache.solr</groupId>
+ <artifactId>solr-solrj</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.apache.httpcomponents</groupId>
+ <artifactId>*</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-client</artifactId>
+ </exclusion>
+ </exclusions>
+ </dependency>
Review Comment:
> why including these dependencies?\n\n`ranger-plugins-audit` previously
supplied all audit destinations as one artifact. Ranger 2.7 separates them, so
declaring all six preserves support for every configured destination; the
exclusions keep their heavy client stacks out of Kyuubi.
##########
extensions/spark/kyuubi-spark-authz/pom.xml:
##########
@@ -70,10 +70,6 @@
<groupId>org.apache.ranger</groupId>
<artifactId>ranger-plugin-classloader</artifactId>
</exclusion>
- <exclusion>
- <groupId>org.apache.ranger</groupId>
Review Comment:
> not needed?\n\n`ranger-plugins-audit` is no longer a transitive dependency
of `ranger-plugins-common` in Ranger 2.7, so this exclusion is obsolete. The
replacement audit artifacts are declared explicitly below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
